RE: [PATCH] USB: gadget: f_mass_storage: fix in error recovery

[Viral Mehta]

>In to places in fsg_common_init() an unconditional call to kfree()
>on common was performed in error recovery which is not a valid
>behaviour since fsg_common structure is not always allocated by
>fsg_common_init().
>
>To fix, the calls has been replaced with a goto to a proper error
>recovery which does the correct thing.
>
>Also, refactored fsg_common_release() function.
In that case,
Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
Reviewed-by: Viral Mehta <viral.mehta@xxxxxxxxxxxxxxx>
>---
>On Wed, 12 May 2010 12:33:43 +0200, Viral Mehta <Viral.Mehta@xxxxxxxxxxxxxxx> wrote:
>> In that case, in addition to your previous patch, below hunk is needed
>>
>> diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
>> index f4911c0..b1648fc 100644
>> --- a/drivers/usb/gadget/f_mass_storage.c
>> +++ b/drivers/usb/gadget/f_mass_storage.c
>> @@ -2883,15 +2883,16 @@ static void fsg_common_release(struct kref *ref)

>This is not entairly true but if you insist, attached is a bit
>different version of your proposed chang.

But, no problem with the earlier patch as well.
______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/