Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() andrmap_walk() during migration by not migrating temporary stacks

[Andrew Morton]

On Wed, 12 May 2010 09:23:44 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > diff --git a/fs/exec.c b/fs/exec.c
> > index 725d7ef..13f8e7f 100644
> > --- a/fs/exec.c
> > +++ b/fs/exec.c
> > @@ -242,9 +242,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> >  	 * use STACK_TOP because that can depend on attributes which aren't
> >  	 * configured yet.
> >  	 */
> > +	BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
> 
> Can we use BUILD_BUG_ON()? 

That's vastly preferable - I made that change.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/