Re: [PATCH 2/8] [nmi watchdog] touch_softlockup cleanups andsoftlockup_tick removal

From: Don Zickus
Date: Wed May 12 2010 - 17:50:49 EST


On Thu, May 13, 2010 at 01:38:14AM +0400, Cyrill Gorcunov wrote:
> On Wed, May 12, 2010 at 11:00:36PM +0200, Frederic Weisbecker wrote:
> ...
> > > >
> > > > Ah right.
> > > >
> > > > BTW, if you address my reviews, please do it incrementally, I'm going
> > > > to apply this set and push it to Ingo.
> > >
> > > Ok, probably easier to review too. :-)
> >
> >
> > Yeah, and it's time to flush this code as it's good globally.
> >
> > Plus it would be nice to get this for .35
> >
> > Ah and forget about the sysctl ABI breakages. Since this is only
> > used for kernel development, this is not going to break much things.
> > If somebody complains, we can still reintegrate what we had.
> >
> > Thanks.
> >
> ...
> Guys, could you please spend a few minutes and enlighten me a bit?
> Does all this series mean that we eventually will drop nmi-watchdog
> via io-apic (read via pic) as only the transition to perf complete?
>
> I recall someone said about to stop using io-apic, but just to be sure.

Right, this code sits on top of the perf subsystem which uses lapic.
Eventually, the old nmi watchdog code will disappear along with the
support for io-apic.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/