Re: [PATCH 2/2] scripts/get_maintainer.pl: add.get_maintainer.conf default options file

[AmÃrico Wang]

On Wed, May 12, 2010 at 11:25:49AM +0200, Florian Mickler wrote:
>On Wed, 12 May 2010 14:30:42 +0800
>AmÃrico Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>
>> On Sun, May 09, 2010 at 09:56:03PM -0700, Joe Perches wrote:
>> >Allow the use of a .get_maintainer.conf file to control the
>> >default options applied when scripts/get_maintainer.pl is run.
>> >
>> >.get_maintainer.conf can contain any valid command-line argument.
>> >
>> >File contents are prepended to any additional command line arguments.
>> >
>> >Multiple lines may be used, blank lines ignored, # is a comment.
>> 
>> Do we really have to do this? This looks odd to me.
>
>it's a little hackish, but the code impact is small. if you prefer
>standard config-file syntax (i.e. "bla=" ) check the patch below. 
>

Better somwhat, but...

>joe, what do you think?
>
>> If the user of get_maintainer.pl uses some long command line
>> arguments, to save his input, he should use bash aliases, not
>> configure files. I never see configure files used like this.
>
>bash aliases don't work (at least here) with "git send-email --cc-cmd="
>
...
>> 
>> Also, it doesn't worthy a configure file for such a script like
>> get_maintainer.pl.
>
>hm.. the only other way to use it via git send-email would be a wrapper
>script? 
>

I still think we should avoid config files as possible as we can.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/