Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() andrmap_walk() during migration by not migrating temporary stacks

[KAMEZAWA Hiroyuki]

On Thu, 13 May 2010 12:22:01 -0500 (CDT)
Christoph Lameter <cl@xxxxxxxxx> wrote:

> On Thu, 13 May 2010, KAMEZAWA Hiroyuki wrote:
> 
> > > Would it not be possible to do something similar for the temporary stack?
> > >
> >
> > Problem here is unmap->remap. ->migratepage() function is used as
> >
> > 	unmap
> > 	   -> migratepage()
> > 	      -> failed
> > 		-> remap
> >
> > Then, migratepage() itself is no help. We need some check-callback before unmap
> > or lock to wait for an event we can make remapping progress.
> 
> We could check earlier if the migrate function points to
> fail_migrate_page()?

If you mean checking before unmap, yes. we can avoid the race.
Unmapping itself is dangerous in this case.

> Where we check for PageKsm() in unmap_and_move f.e.?
> 

I'm not sure about KSM.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/