Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> <resubmission >

[Benjamin Herrenschmidt]

On Fri, 2010-05-14 at 21:44 +0400, Sergei Shtylyov wrote:
> Hello.
> 
> Rupjyoti Sarmah wrote:
> 
> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
> >
> > Signed-off-by: Rupjyoti Sarmah <rsarmah@xxxxxxxxxxxxxxxx> 
> > Signed-off-by: Mark Miesfeld <mmiesfeld@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Prodyut Hazarika <phazarika@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/powerpc/boot/dts/canyonlands.dts |    8 +
> >  drivers/ata/Kconfig                   |    9 +
> >  drivers/ata/Makefile                  |    1 +
> >  drivers/ata/sata_dwc.c                | 1827 +++++++++++++++++++++++++++++++++
> >  4 files changed, 1845 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/ata/sata_dwc.c
> >
> > diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts
> > index cd56bb5..d3b2c99 100644
> > --- a/arch/powerpc/boot/dts/canyonlands.dts
> > +++ b/arch/powerpc/boot/dts/canyonlands.dts
> > @@ -163,6 +163,14 @@
> >  			interrupts = <0x1e 4>;
> >  		};
> >  
> > +		SATA0: sata@bffd1000 {
> > +                        compatible = "amcc,sata-460ex";
> > +			reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>;
> > +                        interrupt-parent = <&UIC3>;
> > +                        interrupts = <0x0 0x4       /* SATA */
> > +                                      0x5 0x4>;     /* AHBDMA */
> > +                };
> > +
> >  		POB0: opb {
> >  			compatible = "ibm,opb-460ex", "ibm,opb";
> >  			#address-cells = <1>;
> >   
> 
>    Please put the device tree update in a separate patch to go thru the 
> PowerPC tree.

Additionally, the boot wrapper should probably either remove the node or
at least use a status property "ok" / "disabled" to represent whether
the board is configured for SATA or PCIe x1...

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/