Re: [PATCH 3/8] block,ide: simplify bdops->set_capacity() to->unlock_native_capacity()

From: David Miller
Date: Sun May 16 2010 - 03:15:50 EST


From: Tejun Heo <tj@xxxxxxxxxx>
Date: Sat, 15 May 2010 20:09:29 +0200

> bdops->set_capacity() is unnecessarily generic. All that's required
> is a simple one way notification to lower level driver telling it to
> try to unlock native capacity. There's no reason to pass in target
> capacity or return the new capacity. The former is always the
> inherent native capacity and the latter can be handled via the usual
> device resize / revalidation path. In fact, the current API is always
> used that way.
>
> Replace ->set_capacity() with ->unlock_native_capacity() which take
> only @disk and doesn't return anything. IDE which is the only current
> user of the API is converted accordingly.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/