Re: [PATCH 1/2] netdev/fec: fix performance impact from mdio polloperation
From: David Miller
Date: Sun May 16 2010 - 03:28:15 EST
From: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Date: Fri, 7 May 2010 10:27:18 +0800
> BugLink: http://bugs.launchpad.net/bugs/546649
> BugLink: http://bugs.launchpad.net/bugs/457878
>
> After introducing phylib supporting, users experienced performace drop. That is
> because of the mdio polling operation of phylib. Use msleep to replace the busy
> waiting cpu_relax() and remove the warning message.
>
> Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
> Acked-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>
As you've already been told, making these MDIO interfaces fail silently
is not acceptable.
Please fix this bug properly and resubmit this patch series.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/