Re: [PATCH] lktdm: Bring support for hardlockup, softlockup andhung task crashes

[Cyrill Gorcunov]

On Sun, May 16, 2010 at 12:35:08PM +0200, Frederic Weisbecker wrote:
...
> > Looks good to me. Btw perhaps we may simplify it a bit:
> > 
> > 	case HARDLOCKUP:
> > 		local_irq_disable();
> > 	case SOFTLOCKUP:
> > 		preempt_disable();
> > 		for (;;)
> > 			cpu_relax();
> > 		break;
> > 
> > since it'll save a few bytes. What do you think? Did I miss
> > something?
> 
> 
> It would make the code a bit less clear in that people
> might stick on the reason to disable preemption after disabling
> irq, especially with a code that already does something rather
> unusual ;)
> 

ok, convinced

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/