Re: [PATCH] Staging: quatech_usb2: Convert eos semaphore to mutex

[Arjan van de Ven]

On Sun, 16 May 2010 00:08:30 +0200
Alessio Igor Bogani <abogani@xxxxxxxxxx> wrote:

> Hi Oliver,
> 
> 2010/5/15 Oliver Neukum <oliver@xxxxxxxxxx>:
> > Am Samstag, 15. Mai 2010 23:40:02 schrieb Alessio Igor Bogani:
> >> The eos semaphore is used as a mutex so replace it with a real
> >> mutex.
> >
> > Documentation/mutex-design.txt states that a mutex must not be used
> > from within an interrupt handler. Is this outdated?
> 
> You are right. Simply I didn't see irqreturn_t return type in function
> prototype.
> 
> Sorry for my mistake.
> 

you might want to convert it to a completion....
that sounds more the usage model that the driver here is doing


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/