Re: [PATCH] GPIO: rdc321x fix inverted gpio data out registers

[Samuel Ortiz]

Hi Florian,

On Sun, May 16, 2010 at 12:02:18PM +0200, Florian Fainelli wrote:
> rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
> 
Patch applied, thanks a lot.

Cheers,
Samuel.


> Signed-off-by: Bernhard Loos <bernhardloos@xxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
> ---
> diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
> index 22f31dc..2762698 100644
> --- a/drivers/gpio/rdc321x-gpio.c
> +++ b/drivers/gpio/rdc321x-gpio.c
> @@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
>  		gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
>  
>  	pci_write_config_dword(gpch->sb_pdev,
> -			reg ? gpch->reg1_data_base : gpch->reg2_data_base,
> +			reg ? gpch->reg2_data_base : gpch->reg1_data_base,
>  			gpch->data_reg[reg]);
>  }
>  

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/