Re: [PATCH] DMA: PL330: Add dma api driver

[Jassi Brar]

On Mon, May 17, 2010 at 6:55 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> On Tue, May 11, 2010 at 10:23 PM, Jassi Brar <jassi.brar@xxxxxxxxxxx> wrote:

>> +static void dma_pl330_rqcb(void *token, enum pl330_op_err err)
>> +{
>> + Â Â Â struct dma_pl330_desc *desc = token;
>> + Â Â Â struct dma_pl330_chan *pch = desc->pchan;
>> + Â Â Â unsigned long flags;
>> +
>> + Â Â Â /* If desc aborted */
>> + Â Â Â if (!pch)
>> + Â Â Â Â Â Â Â return;
>> +
>> + Â Â Â spin_lock_irqsave(&pch->lock, flags);
>> +
>> + Â Â Â desc->status = DONE;
>> +
>> + Â Â Â spin_unlock_irqrestore(&pch->lock, flags);
>
> I don't think you need the lock here. ÂAssigning an integer is atomic,
> and you reschedule the tasklet.
yes right

> Since this patch depends on the generic bits in Russell's tree I need
> to wait until after the ARM tree is pulled to take it through the dma
> tree. ÂSo, for now...
>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/