Re: [uml-devel] [PATCH] UML: x86_64: fix memcpy export

[Paolo Giarrusso]

Shouldn't this thing be in arch/um/sys-i386/ksyms.c, instead of having #ifndef?

On Mon, May 3, 2010 at 01:58, Nicolas Thill <nicolas.thill@xxxxxxxxx> wrote:
> ./arch/um/sys-x86_64/ksyms.c exports memcpy or __memcpy depending on the gcc
> version, use the same logic in ./arch/um/os-Linux/user_syms.c
>
> Signed-off-by: Nicolas Thill <nico@xxxxxxxxxxx>
> ---
> Âarch/um/os-Linux/user_syms.c | Â Â3 ++-
> Â1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/os-Linux/user_syms.c b/arch/um/os-Linux/user_syms.c
> index 89b48a1..e3a12dd 100644
> --- a/arch/um/os-Linux/user_syms.c
> +++ b/arch/um/os-Linux/user_syms.c
> @@ -23,7 +23,8 @@ extern int printf(const char *, ...);
> ÂEXPORT_SYMBOL(strstr);
> Â#endif
>
> -#ifndef __x86_64__
> +#if !defined(__x86_64) || \
> + Â Â Â (__GNUC__ == 4 && __GNUC_MINOR__ < 3) || (__GNUC__ < 4)
> Âextern void *memcpy(void *, const void *, size_t);
> ÂEXPORT_SYMBOL(memcpy);
> Â#endif
> --
> 1.6.0.4
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> User-mode-linux-devel mailing list
> User-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
>



-- 
Paolo Giarrusso
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/