Re: [dm-devel] [RFC PATCH v2 1/2] dm: allow a dm-fs-style device to be shared via dm-ioctl

[Will Drewry]

On Mon, May 17, 2010 at 9:36 PM, Kiyoshi Ueda <k-ueda@xxxxxxxxxxxxx> wrote:
> Hi Will,
>
> n 05/15/2010 10:41 AM +0900, Will Drewry wrote:
>> In addition, it ensures that public functions are available that
>> allow mapped devices and tables to be created and associated
>> with the shared code paths with dm-ioctl:
>> - suspend flags are available
> snip
>> diff --git a/drivers/md/dm.h b/drivers/md/dm.h
>> index bad1724..782d867 100644
>> --- a/drivers/md/dm.h
>> +++ b/drivers/md/dm.h
>> @@ -17,12 +17,6 @@
>>  #include <linux/hdreg.h>
>>
>>  /*
>> - * Suspend feature flags
>> - */
>> -#define DM_SUSPEND_LOCKFS_FLAG               (1 << 0)
>> -#define DM_SUSPEND_NOFLUSH_FLAG              (1 << 1)
>> -
>> -/*
>>   * Type of table and mapped_device's mempool
>>   */
>>  #define DM_TYPE_NONE         0
>> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
>> index 1381cd9..6c1c230 100644
>> --- a/include/linux/device-mapper.h
>> +++ b/include/linux/device-mapper.h
>> @@ -215,6 +215,18 @@ void dm_set_mdptr(struct mapped_device *md, void *ptr);
>>  void *dm_get_mdptr(struct mapped_device *md);
>>
>>  /*
>> + * Export the device via the ioctl interface (uses mdptr).
>> + */
>> +int dm_ioctl_export(struct mapped_device *md, const char *name,
>> +                 const char *uuid);
>> +
>> +/*
>> + * Suspend feature flags
>> + */
>> +#define DM_SUSPEND_LOCKFS_FLAG               (1 << 0)
>> +#define DM_SUSPEND_NOFLUSH_FLAG              (1 << 1)
>> +
>> +/*
>>   * A device can still be used while suspended, but I/O is deferred.
>>   */
>>  int dm_suspend(struct mapped_device *md, unsigned suspend_flags);
>
> Why do you need suspend feature flags?
> I think no feature is needed (specifying '0' is enough) to make/suspend
> a dm device at boot time (although I have looked at only this flag part).
> Am I missing something?

Not at all! I hadn't thoroughly reviewed the code path for flush/noflush
and was hoping to avoid additional code paths.  However, looking at
effect, I don't see any tangible benefit to doing so with a brand new
device.

I'll switch it over to 0, and I can take exposing the flags out of this
patch.

Any additional comments are appreciated -  thanks!
will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/