Re: [PATCH 1/1] hidraw: Use Interrupt Endpoint for OUT Transfers ifAvailable

From: Jiri Kosina
Date: Tue May 18 2010 - 04:44:19 EST


On Sun, 16 May 2010, Alan Ott wrote:

> From: Alan Ott <alan@xxxxxxxxxxx>
>
> This patch makes the hidraw driver use the first Interrupt OUT endpoint for
> HID transfers to the device if such an endpoint exists. This is consistent
> with the behavior of the hiddev driver, and the logic is similar.
>
> Signed-off-by: Alan Ott <alan@xxxxxxxxxxx>
> ---
> I believe this to be consistent with the section 4.4 of the HID 1.11
> specification located at:
> http://www.usb.org/developers/devclass_docs/HID1_11.pdf
>
> >From the specification (page numbered 10, the 20th page of the document
> (xpdf page 20)):
>
> The Interrupt Out pipe is optional. If a device declares an Interrupt Out
> endpoint then Output reports are transmitted by the host to the device
> through the Interrupt Out endpoint. If no Interrupt Out endpoint is
> declared then Output reports are transmitted to a device through the
> Control endpoint, using Set_Report(Output) requests.
>
> This is also consistent with the way the Windows HID library (hid.dll)
> works.

Yes, this definitely is a proper improvement. Thanks Alan, I have queued
the patch.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/