[RFC PATCH] perf: align raw sample data on 64-bit boundaries
From: Robert Richter
Date: Tue May 18 2010 - 11:12:51 EST
On 19.04.10 14:19:57, Stephane Eranian wrote:
> > + perf_sample_data_init(&data, 0);
> > + if (event->attr.sample_type & PERF_SAMPLE_RAW) {
> > + for (i = 1; i < size; i++)
> > + rdmsrl(msr++, *buf++);
> > + raw.size = sizeof(u64) * size;
> > + raw.data = buffer;
> > + data.raw = &raw;
> > + }
> > +
>
> Need to add the padding: raw.size = sizeof(u64) * size + sizeof(u32);
When thinking about this I was wondering if it wouldn't make sense to
better fix the alignment and move the data buffer to a 64 bit
boundary. So take a look at the enclosed RFC patch. Though it breaks
the ABI it would solve some problems. I think more than it introduces.
Hopefully I found all effected code locations using it.
-Robert
--