RE: [PATCH] x86: Export tsc related information in sysfs

From: Dan Magenheimer
Date: Tue May 18 2010 - 15:17:44 EST


> From: Dan Magenheimer
>
> > From: H. Peter Anvin [mailto:hpa@xxxxxxxxx]
> > Subject: Re: [PATCH] x86: Export tsc related information in sysfs
> >
> > On 05/18/2010 10:49 AM, Dan Magenheimer wrote:
> > >
> > > (Though I expect tglx/arjan/andi/mingo to disagree with this
> proposal
> > > for similar reasons as the original one that started this
> thread...)
> >
> > I'll add another reason to disagree: exporting these as sysfs
> variables
> > is non-atomic, but these are really only useful when atomically read
> as
> > a unit.
>
> Which "these"? The counters? I would think the primary use
> of the counters is to diagnose extreme problem cases, not
> to differentiate whether a system or process did exactly
> 27 vs 28 rdtsc's, so I don't see why atomic read is at all
> necessary.
>
> Or did I miss your point entirely?

Oops, hit send too soon.

And the reason I expect tglx/arjan/andi/mingo to disagree is because
their position is that there is NO safe use for rdtsc in userspace EVER!
Whereas your position stated earlier:

> There are restricted uses of the TSC in userspace which are still
> useful
> (mainly involving performance analysis and/or CPU-locked processes).

says there are.

While the engineer in me agrees with tglx/arjan/andi/mingo, the
realist in me agrees with you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/