Re: [BUG] SLOB breaks Crypto
From: Pekka Enberg
Date: Tue May 18 2010 - 17:15:56 EST
Hi David,
On Tue, May 18, 2010 at 11:59 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Matt Mackall <mpm@xxxxxxxxxxx>
> Date: Tue, 18 May 2010 14:33:55 -0500
>
>> SLOB honors ARCH_KMALLOC_MINALIGN. If your arch has alignment
>> requirements, I recommend you set it.
>
> I recommend that the alignment provided by the allocator is not
> determined by which allocator I happen to have enabled.
>
> The values and ifdef'ery should be identical in all of our
> allocators.
Why? It doesn't make much sense for SLOB, which tries to be as space
efficient as possible, as a default. If things break on sparc, it
really needs to set ARCH_KMALLOC_MINALIGN as slab default alignment is
not something you really want to depend on.
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/