Re: [PATCH] power/ds2760_battery: document ABI change

[Anton Vorontsov]

On Tue, May 18, 2010 at 10:30:49PM +0200, Daniel Mack wrote:
> >From 7ed6b078c1cb718509a0faf79ac53f768fa5cfc4 Mon Sep 17 00:00:00 2001
> From: Daniel Mack <daniel@xxxxxxxx>
> Date: Tue, 18 May 2010 22:26:40 +0200
> Subject: [PATCH] power/ds2760_battery: document ABI change
> 
> Add some documentation for the newly added writeable properties.
> 

I added 'Suggested-by: Greg KH <gregkh@xxxxxxx>' tag here.

> Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
> ---
> On Tue, May 18, 2010 at 12:56:24PM -0700, Greg KH wrote:
> > On Tue, May 18, 2010 at 09:49:52PM +0200, Daniel Mack wrote:
> > > This patch adds support for writeable power supply properties and
> > > exposes them as writeable to sysfs.
> > 
> > Please properly document this in Documentation/ABI as you are changing
> > the userspace ABI.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Is something like the following appropriate?

Looks good to me, as well as patches 1-3 (though in the first patch
I fixed power_supply_attr_groups to be static, it was a negligence
from my original patch).

I applied all these patches to battery-2.6.git, thanks!

-- 
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/