Re: [PATCH v4 10/13] trace: Common code for kprobes/uprobes traceevents

[Masami Hiramatsu]

Srikar Dronamraju wrote:
>>
>> Isn't it a common header for kprobes and uprobes? :)
>>
>> Maybe "Probe-based dynamic events common header" ?
>>
> 
> Agree.
> 
>>> +#define MAX_TRACE_ARGS 128
>>> +#define MAX_ARGSTR_LEN 63
>>> +#define MAX_EVENT_NAME_LEN 64
>>> +#define UPROBE_EVENT_SYSTEM "uprobes"
>>
>> You should *just move* the common code in this patch.
>> Additional uprobes code can be introduced in next patch.
>>
> 
> Okay.
> 
>>> +
>>> +/* Flags for trace_probe */
>>> +#define TP_FLAG_TRACE	1
>>> +#define TP_FLAG_PROFILE	2
>>> +#define UPROBE_ENABLED	4
>>
>> If this is a trace_probe flag, it is better to start with TP_FLAG_.
> 
> Okay.
> Does TP_FLAG_UPROBE sound fine?

Sure, that's good for me:)

Thank you,


-- 
Masami Hiramatsu
e-mail: mhiramat@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/