Re: [PATCH] MFD of DA9052 Linux device drivers (1/9)

[Randy Dunlap]

On Wed, 19 May 2010 10:16:10 +0100 David Dajun Chen wrote:

Hi,
2 comments from a quick scan:



> diff -Naur linux-2.6.33.2/drivers/mfd/Kconfig linux-2.6.33.2_patch/drivers/mfd/Kconfig
> --- linux-2.6.33.2/drivers/mfd/Kconfig	2010-04-02 04:02:33.000000000 +0500
> +++ linux-2.6.33.2_patch/drivers/mfd/Kconfig	2010-05-18 15:30:37.000000000 +0500
> @@ -348,6 +348,35 @@
>  	  read/write functions for the devices to get access to this chip.
>  	  This chip embeds various other multimedia funtionalities as well.
>  
> +config MFD_DA9052
> +	bool "Dialog Semiconductor DA9052 PMIC Support"

a.  why are all of these drivers "bool" (y/n) instead of tristate (y/m/n)?
i.e., why are they not buildable as loadable modules?


> +	help
> +	  Say yes here to support for Dialog semiconductor Da9052, Power
> +	  Management IC.This option enables the SPI/I2C, EH, and ADC
> +	  features of DA9052.
> +choice
> +	prompt "DA9052 SSC support"
> +	depends on MFD_DA9052
> +config MFD_DA9052_SPI
> +	bool "SPI"
> +	select SPI
> +	select GPIOLIB
> +	help
> +	  Say Y  to select SPI serial interface for DA9052 chip
> +
> +config MFD_DA9052_I2C
> +	bool "I2C"
> +	select I2C
> +	help
> +	  Say Y  to select I2C serial interface for DA9052 chip
> +endchoice
> +
> +config DA9052_ADC_ENABLE
> +	bool "Dialog Semiconductor DA9052 ADC Driver"
> +	depends on MFD_DA9052
> +	help
> +	  Say Y  to enable the ADC driver for the DA9052 chip
> +
>  endmenu
>  
>  menu "Multimedia Capabilities Port drivers"


b.  The .c and .h files have lots of comments in them that begin with "/**",
which in kernel-land means kernel-doc notation... but they are not in kernel-doc
notation.  Please see Documentation/kernel-doc-nano-HOWTO.txt for info on how
to use kernel-doc notation.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/