Re: [patch] pipe: add support for shrinking and growing pipes

[Jens Axboe]

On Wed, May 19 2010, Linus Torvalds wrote:
> 
> 
> On Wed, 19 May 2010, Miklos Szeredi wrote:
> > 
> > One issue I see is that it's possible to grow pipes indefinitely.
> > Should this be restricted to privileged users?
> 
> Yes. But perhaps only if it grows past the default (or perhaps "default*2" 
> or similar). That way a normal user could shrink the pipe buffers, and 
> then grow them again if he wants to.

That's still a bit arbitrary, I don't think allowing default*2 only for
non-root is going to be hugely interesting. But limiting makes sense,
but lets at least allow a larger max limit for the normal user. I'm
suspecting that the media application that wants to use this will not be
running as root, and we don't make the feature properly available to the
ones that want to use it, then we may as well not do it.

Or we could expose a sysctl for instance that holds the max non-root
size. And make that default to default*16 or something. How does that
sound?

> Oh, and I think you need to also require that there be at least two 
> buffers. Otherwise we can't guarantee POSIX behavior, I think.

Good point, and at least that part is easily doable :-)

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/