Re: [PATCH 2/2] Hyperv detection - code cleanup

From: Ky Srinivasan
Date: Wed May 19 2010 - 14:33:48 EST




>>> On 5/19/2010 at 2:21 PM, in message <4BF42C3D.6030404@xxxxxxxxx>, "H. Peter
Anvin" <hpa@xxxxxxxxx> wrote:
> On 05/19/2010 11:19 AM, Greg KH wrote:
>> On Wed, May 19, 2010 at 10:50:54AM -0700, H. Peter Anvin wrote:
>>> On 05/19/2010 10:20 AM, Ky Srinivasan wrote:
>>>> From: K. Y. Srinivasan <ksrinivasan@xxxxxxxxxx>
>>>> Subject: Code cleanup - get rid of the "ms" prefix in hyperv related files.
>>>>
>>>>
>>>> Signed-off-by: K. Y. Srinivasan <ksrinivasan@xxxxxxxxxx>
>>>
>>> NAK in the extreme.
>>>
>>> "hyperv" -- without the capitalization to make it stand out -- is way
>>> too easy to read as just an abbreviation for "hypervisor".
>>
>> Which is what I confused it with, and hence I wrote the ms_* changes in
>> my patch. But KY wanted it changed back so I suggested he write a
>> patch.
>>
>> I personally like the ms_ stuff, it makes it more obvious what is going
>> on here, but that's just me.
>>
>
> Well, I agree with you. Sorry, Ky.
I see your concern.

Regards,

K. Y
>
> -hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/