Re: [PATCH 2/2] x86, mem-hotplug: update all PGDs for direct mappingand vmemmap mapping changes on 64bit.

From: Haicheng Li
Date: Wed May 19 2010 - 23:52:20 EST


Wu Fengguang wrote:
@@ -1033,6 +1038,7 @@ vmemmap_populate(struct page *start_page, unsigned long size, int node)
}

}
+ sync_global_pgds((unsigned long)start_page, end);

Here you removed the tlb flush in the original patch. Is it safe to do so?

Yes, I think so. Before this populate, such vmemmap mapping should be always zero, so it's optional to do tlb flush here.

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/