Re: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat

[Frederic Weisbecker]

On Fri, May 14, 2010 at 09:44:24AM +0200, Peter Zijlstra wrote:
> On Thu, 2010-05-13 at 21:03 +0200, Frederic Weisbecker wrote:
> > hlist = rcu_dereference_check(ctx->swevent_hlist,
> >                               rcu_read_lock_held() ||
> >                               raw_spin_lock_is_held(&ctx->lock)); 
> 
> raw_spin_lock_is_held() is wrong, that should read:
> lockdep_is_held(&ctx->lock).
> 
> raw_spin_lock_is_held() only checks if the lock is locked,
> lockdep_is_held() ensures we are the one holding it.


Right!

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/