Re: [PATCH] sysfs: compile fix, struct file forward declaration

[Chris Wright]

* Greg KH (greg@xxxxxxxxx) wrote:
> On Tue, May 18, 2010 at 03:32:19PM -0700, Chris Wright wrote:
> > On Tue, May 18, 2010 at 04:44:09PM +1000, Stephen Rothwell wrote:
> > > After merging the driver-core tree, today's linux-next build (powerpc
> > > ppc64_defconfig) failed like this:
> > > 
> > > cc1: warnings being treated as errors
> > > In file included from include/linux/kobject.h:21,
> > >                  from include/linux/device.h:17,
> > >                  from arch/powerpc/lib/devres.c:10:
> > > include/linux/sysfs.h:97: error: 'struct file' declared inside parameter list
> > > include/linux/sysfs.h:97: error: its scope is only this definition or
> > > declaration, which is probably not what you want
> > > include/linux/sysfs.h:99: error: 'struct file' declared inside parameter list
> > > include/linux/sysfs.h:101: error: 'struct file' declared inside parameter list
> > > 
> > > and many more (arch/powerpc is built with -Werror (as do some other
> > > architectures)) and lots of similar warnings ...
> > 
> > Add missing forward declaration
> > 
> > Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
> 
> Thanks, now merged in.

Thanks Greg, sorry about the mess up.
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/