Re: [PATCH 1/3] cgroups: Add an API to attach a task to current task'scgroup

From: Sridhar Samudrala
Date: Fri May 21 2010 - 11:09:50 EST


On 5/20/2010 3:22 PM, Paul Menage wrote:
On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala
<samudrala.sridhar@xxxxxxxxx> wrote:
Add a new kernel API to attach a task to current task's cgroup
in all the active hierarchies.

Signed-off-by: Sridhar Samudrala<sri@xxxxxxxxxx>
Reviewed-by: Paul Menage<menage@xxxxxxxxxx>

It would be more efficient to just attach directly to current->cgroups
rather than potentially creating/destroying one css_set for each
hierarchy until we've completely converged on current->cgroups - but
that would require a bunch of refactoring of the guts of
cgroup_attach_task() to ensure that the right can_attach()/attach()
callbacks are made. That doesn't really seem worthwhile right now for
the initial use, that I imagine isn't going to be
performance-sensitive.
Yes. In our use-case, this will be called only once per guest interface when the guest comes up.
Hope you or someone more familiar with cgroups subsystem can optimize this function later.

Thanks
Sridhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/