Re: [PATCH] compat-wireless: add linux-next-pending, crap patchdirs and nagometer

[Pavel Roskin]

On Fri, 2010-05-21 at 20:44 -0400, Luis R. Rodriguez wrote:
> Sometimes you have no other option but to carry around patches.
> This can happen for a variety of reasons. Ultimately testing of code
> cannot happen on the kernel maintainer's clock but on your own.
> 
> This expands the idea of the linux-next-cherry-pick patch directory
> on compat-wireless to also allow for patches to be merged which are
> posted to some mailing list but pending merge due to some reasons
> (merge window is a good example). It also adds a crap patch directory
> for those really nasty situations you can run into where you have
> no other option but to give someone a release with some delta even
> if the patch is not yet posted anywhere.

Please replace "crap" with some more descriptive name, like
"unpublished".  It's better to be friendly to users and express
frustration in a different way.

> +	printf "${RED}%10s${NORMAL} - Crap changes not yet posted\n" $2
> +	printf "${RED}%10s${NORMAL} - Crap additions not yet merged\n" $3
> +	printf "${RED}%10s${NORMAL} - Crap deletions not yet posted\n" $4

You want "not yet posted" in all cases.

"Crap deletions" may be offensive for Linux contributors whose code is
being deleted.  Besides, if patches are not posted, somebody still spent
time on making them.  Let's not discourage those who care.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/