Re: [PATCH] mfd: section cleanup of 88pm860x driver

[Mike Frysinger]

On Thu, Mar 25, 2010 at 21:40, Henrik Kretzschmar wrote:
_device_init(struct pm860x_chip *chip,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct pm860x_platform_data *pdata);
> -extern void pm860x_device_exit(struct pm860x_chip *chip);
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct pm860x_platform_data *pdata) __devinit ;
> +extern void pm860x_device_exit(struct pm860x_chip *chip) __devexit ;
>
> Â#endif /* __LINUX_MFD_88PM860X_H */

i took a second look and noticed that this hunk is useless.  as long
as the func definitions have proper markings, the prototypes wrt
section markings here is irrelevant.  plus, you add a spurious space
before the semicolon.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/