Re: [PATCH] x86: Export tsc related information in sysfs

From: Brian Bloniarz
Date: Tue May 25 2010 - 22:50:50 EST


john stultz wrote:
> On Tue, 2010-05-25 at 20:16 -0400, Brian Bloniarz wrote:
>> On 05/24/2010 09:33 PM, Brian Bloniarz wrote:
>>> So what's wrong with just adding a
>>> /sys/devices/system/clocksource/clocksource0/tsc_khz?
>> As an RFC:
>>
>> Add clocksource.sys_register & sys_unregister so the
>> current clocksource can add supplemental information to
>> /sys/devices/system/clocksource/clocksource0/
>>
>> Export tsc_khz when current_clocksource==tsc so that
>> daemons like NTP can account for the variability of
>> calibration results.
>
> I think this is a bad idea, as it creates an ABI that is arch AND
> machine specific, which will cause portability problems in applications
> that expect the interface to be there.

It's an arch-independent ABI that returns ENOENT on
unsupported platforms ;)

Could you please explain what you envision as an
arch-independent solution to this problem?
I guess the tsc_long_calibration=1 alternative is
one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/