Re: [rtc-linux] [PATCH] rtc: driver for the DryIce block found in i.MX25 chips

[Wan ZongShun]

2010/6/7 Baruch Siach <baruch@xxxxxxxxxx>:
> Hi Wan,
>
> On Sat, Jun 05, 2010 at 11:08:46PM +0800, Wan ZongShun wrote:
>> Some minor comments below:
>
> One question though.
>
>> > +/*
>> > + * read the seconds portion of the current time from the dryice time counter
>> > + */
>> > +static int dryice_rtc_read_time(struct device *dev, struct rtc_time *tm)
>> > +{
>> > + Â Â Â struct imxdi_dev *imxdi = dev_get_drvdata(dev);
>> > + Â Â Â unsigned long now;
>> > +
>> > + Â Â Â now = __raw_readl(imxdi->ioaddr + DTCMR);
>> > + Â Â Â rtc_time_to_tm(now, tm);
>> > +
>>
>> When we want to return a tm value, call rtc_valid_tm() to check the tm
>> that is a good habit.
>
> Isn't rtc_time_to_tm() guaranteed to produce a valid tm value?
>

Yes, it can.


>>
>> > + Â Â Â return 0;
>> > +}
>
> baruch
>
> --
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ~. .~ Â Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> Â - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
>



-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@xxxxxxxxxxxxxxxx
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/