Re: [PATCH] Documentation/filesystems/xip.txt: clarify the statement: The block device option is mandatory for execute-in-place

[shenghui]

2010/6/8 Dan Carpenter <error27@xxxxxxxxx>:
> On Tue, Jun 08, 2010 at 04:37:04PM +0800, shenghui wrote:
>> diff --git a/Documentation/filesystems/xip.txt
>> b/Documentation/filesystems/xip.txt
>> index 0466ee5..bef4120 100644
>> --- a/Documentation/filesystems/xip.txt
>> +++ b/Documentation/filesystems/xip.txt
>> @@ -35,8 +35,7 @@ is performed. A struct block_device reference is
>> used to address the device,
>
> I don't know about xip, but the patch is malformed. ÂIt's line wrapped
> here.
>
>> Âand a sector_t argument is used to identify the individual block. As an
>> Âalternative, memory technology devices can be used for this.
>>
>> -The block device operation is optional, these block devices support it as of
>> -today:
>> +The block device operation is mandatory for execute-in-place, these
>> block devices support it as of today:
>
> And here.
>
>> Â- dcssblk: s390 dcss block device driver
>>
>
> There is documentation in Documentation/email-clients.txt. ÂSend a patch
> to yourself, then save it as a raw document.
>
> cd path/to/linux
> cat raw-email | patch -p1
>
> If it applies correctly resend your patch to the list.
>
> regards,
> dan carpenter
>
>
>

Signed-off-by: Wang Sheng-Hui <crosslonelyover@xxxxxxxxx>
---
 Documentation/filesystems/xip.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/filesystems/xip.txt
b/Documentation/filesystems/xip.txt
index 0466ee5..caaa8b4 100644
--- a/Documentation/filesystems/xip.txt
+++ b/Documentation/filesystems/xip.txt
@@ -35,8 +35,8 @@ is performed. A struct block_device reference is
used to address the device,
 and a sector_t argument is used to identify the individual block. As an
 alternative, memory technology devices can be used for this.

-The block device operation is optional, these block devices support it as of
-today:
+The block device operation is mandatory for execute-in-place, these block
+devices support it as of today:
 - dcssblk: s390 dcss block device driver

 An address space operation named get_xip_mem is used to retrieve references
-- 
1.7.0.1


-- 


Thanks and Best Regards,
shenghui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/