Re: [Xen-devel] [PATCH 02/12] early PV on HVM

[Stefano Stabellini]

On Tue, 8 Jun 2010, Konrad Rzeszutek Wilk wrote:
> > > > +	HYPERVISOR_shared_info = (struct shared_info *)shared_info_page;
> > > > +
> > > > +	/* Don't do the full vcpu_info placement stuff until we have a
> > > > +	   possible map and a non-dummy shared_info. */
> > > 
> > > Might want to mention where the full vpcu placement is done.
> > 
> > The comment is not accurate, we actually don't do any vcpu_info
> > placement on hvm because it is not very useful there.
> > Better just to remove the comment (I have done so in my tree).
> > 
> > > > +	per_cpu(xen_vcpu, 0) = &HYPERVISOR_shared_info->vcpu_info[0];
> > > 
> So.. what is the purpose of the per_cpu(xen_vcpu, 0) then?
> 

the vcpu info placement memory area is stored in per_cpu(xen_vcpu_info, cpu);
per_cpu(xen_vcpu, cpu) is just a pointer to that area if it is
available, otherwise it points to the vcpu_info struct in the shared
info page.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/