Re: [PATCH 00/17] MAINTAINERS: Add drivers/staging entries

[Joe Perches]

On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote:
> On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> > Some drivers/staging directories use a TODO file with email entries.
> > Make the same entries in the normal MAINTAINERS file.
> 
> No, please don't do this.  I don't want to clutter up the MAINTAINERS
> file with staging stuff.

It's not clutter when it helps get patches to the right reviewers
or responsible parties.

> The get_maintainer.pl script handles staging
> patches just fine today without this being needed at all.

Dubious.

Many of these nominal maintainer email entries are not
found in git logs.

For instance:

$ grep "@" drivers/staging/dt3155/TODO
Please send patches to Greg Kroah-Hartman <greg@xxxxxxxxx>
and Scott Smedley <ss@xxxxxxxxxx>

$ ./scripts/get_maintainer.pl -f drivers/staging/dt3155/
Greg Kroah-Hartman <gregkh@xxxxxxx>
Simon Horman <horms@xxxxxxxxxxxx>
H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
devel@xxxxxxxxxxxxxxxxxxxx
linux-kernel@xxxxxxxxxxxxxxx

Some have cc:'d entries, but not many actually have
Signed-off-by's.  Perhaps that's because the individuals
are not frequently cc'd on the actual patches.  Perhaps
because the people that put their names in the TODO's
just don't care.

> I also found it a bit odd you didn't send these to the stable subsystem
> maintainer, why?

The MAINTAINERS patches are forward going, not historical.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/