Re: floppy driver assumes INITIAL_JIFFIES == 0

[Stephen Hemminger]

On Thu, 3 Jun 2010 16:21:55 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> 
> 
> On Thu, 3 Jun 2010, Stephen Hemminger wrote:
> > 
> > Maybe putting all back together in a threaded_irq would be safest.
> 
> Yes. That floppy driver could easily be a good case for using those 
> threaded irq's. The problem, of course, is to find somebody motivated 
> enough. The code-base really is pretty dang ugly, and it might be hard to 
> do it incrementally, I think.
> 
> (And starting from scratch is likely not a great idea either - while 
> _some_ of the ugliness comes from the odd irq-driven state machine code, a 
> lot of it also comes from trying to handle all those floppy formats etc)
> 
> 			Linus

I have fixes to stop the panic, but will hold off until 2.6.36.
For now want to make sure that there is no chance of causing worse problems
on real hardware.  There is no
reason there should ever be I/O error's and panic when running on virtual
hardware.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/