Re: [RFC PATCH 1/2] mac80211: make max_network_latency notifieratomic safe

From: Johannes Berg
Date: Wed Jun 09 2010 - 05:38:34 EST


On Wed, 2010-06-09 at 11:15 +0200, florian@xxxxxxxxxxx wrote:
> In order to have the pm_qos framework be callable from interrupt
> context, all listeners have to also be callable in that context.

That makes no sense at all. Why add work structs _everywhere_ in the
callees and make the API harder to use and easy to get wrong completely,
instead of just adding a single work struct that will be queued from the
caller and dealing with the locking complexity etc. just once.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/