Re: [PATCH] FRV: Implement the GDB remote protocol 'p' command to retrieve a register

From: David Howells
Date: Wed Jun 09 2010 - 14:51:26 EST


Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> > Implement the GDB remote protocol 'p' command to retrieve a single register
> > value.
>
> Is there any value to this? Apparently it used to work just because that
> command never did anything (rather than return an error). Why not just
> reinstate that behavior instead?

That's a reasonable argument. The 'p' command would be more efficient if gdb
uses it when required to get single values, but once it has decided to use the
'g' command, it seems to stick with it.

> There's doesn't seem to be any reason to implement the single-register
> case unless there is some legacy use of it. There's a good reason gdb
> tends to use the "register block" thing, and it tends to be easier to
> implement too (no crazy case statements etc).

It's slower to use 'g', however, if we only want the value in one register,
and I'm usually doing gdb protocol over serial.

However, as stated above, once it's decided to use 'g', gdb doesn't seem to
want to use 'p' any more.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/