Re: [PATCH] input: fixup X86_MRST selects

From: Randy Dunlap
Date: Wed Jun 09 2010 - 18:43:29 EST


On 06/09/10 15:40, Dmitry Torokhov wrote:
> On Wednesday, June 09, 2010 03:29:21 pm Randy Dunlap wrote:
>> +++ linux-next-20100609/drivers/input/keyboard/Kconfig
>> @@ -70,9 +70,10 @@ config KEYBOARD_ATARI
>>
>> config KEYBOARD_ATKBD
>> tristate "AT keyboard" if EMBEDDED || !X86
>> + depends on !X86 || (X86 && !X86_MRST)
>
> Should it be simply 'depends on !X86_MRST' and then we could kill
> '!X86_MRST' conditionals in selects?

Duh, that sounds good, yes.

>
>> default y
>> select SERIO
>> - select SERIO_LIBPS2
>> + select SERIO_LIBPS2 if !X86_MRST
>> select SERIO_I8042 if X86 && !X86_MRST
>> select SERIO_GSCPS2 if GSC
>> help
>
> Thanks.
>


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/