Re: [PATCH] Marvell OpenRD-Ultimate machine support

[Dmytro Milinevskyy]

Hi!

You are right, I didn't notice that it's called via subsys_initcall.

-- Dima

On Thu, Jun 10, 2010 at 8:50 AM, Alexander Clouter <alex@xxxxxxxxxxxxx> wrote:
> Hi,
>
> * Dmytro Milinevskyy <milinevskyy@xxxxxxxxx> [2010-06-10 05:24:56+0300]:
>>
>> [snipped]
>>
>> @@ -84,8 +90,7 @@ static void __init openrd_init(void)
>>
>>  static int __init openrd_pci_init(void)
>>  {
>> -     if (machine_is_openrd_base() || machine_is_openrd_client())
>> -             kirkwood_pcie_init();
>> +     kirkwood_pcie_init();
>>
>>       return 0;
>>  }
>>
> You just 'broke' kirkwood, welcome to the club.  We all have done this:
>
> http://marc.info/?l=linux-arm-kernel&m=125624586625065&w=2
> http://marc.info/?l=linux-arm-kernel&m=125804222219159&w=2
>
> Put that 'if()' clause back in, the 'subsys_initcall(openrd_pci_init)'
> causes that code to run on *all* compiled in boards (think of the case
> where you have SheevaPlug's also enabled).
>
> Cheers
>
> --
> Alexander Clouter
> .sigmonster says: Poverty begins at home.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/