Re: [PATCH] sata_sil24: Use memory barriers before issuing commands

[Tejun Heo]

On 06/10/2010 04:57 PM, Catalin Marinas wrote:
> The data in the cmd_block buffers may reach the main memory after the
> writel() to the device ports. This patch introduces two calls to wmb()
> to ensure the relative ordering.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> Tested-by: Colin Tuckley <colin.tuckley@xxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>

Can you please add comments explaining why they're needed?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/