Re: [PATCH 02/13] jump label v9: base patch

[Ingo Molnar]

* Jason Baron <jbaron@xxxxxxxxxx> wrote:

> > > +			entry = add_jump_label_entry((char *)iter_begin->name,
> > > +							count, iter_begin);
> > > +			if (IS_ERR(entry))
> > > +				return PTR_ERR(entry);
> > > +			continue;
> > > +		}
> > > +		WARN(1, KERN_ERR "build_jump_hashtable: unexpected entry!\n");
> > 
> > 
> > 
> > It seems you are going to endless loop in this fail case.
> > 
> 
> agreed. I need to stick that 'WARN' into the else clause of "if
> (!entry)" and return an error.

and make that WARN_ONCE() as well. If it ever triggers it should show up once 
and not compound the bug with spamming the console and the logs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/