Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

From: Avi Kivity
Date: Fri Jun 11 2010 - 00:57:01 EST


On 06/11/2010 04:58 AM, Tom Lyon wrote:
On Thursday 10 June 2010 10:27:36 am Konrad Rzeszutek Wilk wrote:
+EXPORT_SYMBOL(uiommu_fdget);
EXPORT_SYMBOL_GPL
.. snip
+EXPORT_SYMBOL(uiommu_put);
ditto.

Is there a definitive explanation somewhere of when to use each?

Always use _GPL unless you have a defensible reason why you shouldn't. The kernel's license if GPL, exporting a symbol without GPL can be seen as adding an exception to the license.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/