Re: [PATCH] staging/wlags49_hs: Fix build error when CONFIG_SYSFS is not set

[Javier Martinez Canillas]

>> Âextern void register_wlags_sysfs(struct net_device *);
>> Âextern void unregister_wlags_sysfs(struct net_device *);
>> Â#else
>> -static void register_wlags_sysfs(struct net_device *) { return; };
>> -static void unregister_wlags_sysfs(struct net_device *) { return; };
>> +#define register_wlags_sysfs(net_device) { }
>> +#define unregister_wlags_sysfs(net_device) { }
>> Â#endif
>
> Yes, that works, but a better fix would be to remove the
> semicolons after the function close braces.
> ---

Why would it be better? With a macro you avoid the overhead of a
function call that does nothing.
I personally think a macro fit better in this case.

Best regards,

-----------------------------------------
Javier MartÃnez Canillas
+595 981 88 66 58
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/