Re: [PATCH 5/6]kernel:module.c variable 'nowarn' set but not used

[Geert Uytterhoeven]

On Fri, Jun 11, 2010 at 22:41, Justin P. Mattock
<justinmattock@xxxxxxxxx> wrote:
> The below patch fixes a warning message
> reported by gcc 4.6.0.
>
> ÂCC Â Â Âkernel/module.o
> kernel/module.c: In function 'add_usage_links':
> kernel/module.c:1343:6: warning: variable 'nowarn' set but not used
>
> ÂSigned-off-by: Justin P. Mattock <justinmattock@xxxxxxxxx>
>
> ---
> Âkernel/module.c | Â Â8 ++------
> Â1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 8c6b428..a71027a 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1340,13 +1340,9 @@ static void add_usage_links(struct module *mod)
> Â{
> Â#ifdef CONFIG_MODULE_UNLOAD
> Â Â Â Âstruct module_use *use;
> - Â Â Â int nowarn;
> -
> +
> Â Â Â Âmutex_lock(&module_mutex);
> - Â Â Â list_for_each_entry(use, &mod->target_list, target_list) {
> - Â Â Â Â Â Â Â nowarn = sysfs_create_link(use->target->holders_dir,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&mod->mkobj.kobj, mod->name);
> - Â Â Â }
> + Â Â Â list_for_each_entry(use, &mod->target_list, target_list);
> Â Â Â Âmutex_unlock(&module_mutex);
> Â#endif
> Â}

Also wrong, you removed the creation of the links in sysfs.

The assignment to nowarn was there to avoid another compiler warning,
as sysfs_create_link() is marked __must_check.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/