Re: [PATCH v2 1/2] tmpfs: Quick token library to allow scalableretrieval of tokens from token jar

[Andrew Morton]

On Thu, 10 Jun 2010 10:06:14 -0700
Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> wrote:

> On Wed, 2010-06-09 at 15:36 -0700, Andrew Morton wrote:
> 
> > > 
> > > You need some synchronization, otherwise the accounting
> > > would not be exact and you could overflow. Yes you could
> > > open code it, but having it in a library is nicer.
> > 
> > The code doesn't have synchronisation!  qtoken_return() can modify the
> > per-cpu "cache" in parallel with qtoken_avail()'s walk across the
> > per-cpu "caches", yielding an inaccurate result.
> > 
> > This is all the same as percpu_add() executing in parallel with
> > percpu_counter_sum() or percpu_counter_sum_positive().
> > 
> > If we cannot tolerate that inaccuracy then these patches are no good
> > and we need a rethink.
> > 
> > If we _can_ tolerate that inaccuracy then percpu_counters can be used
> > here.  And doing that is preferable to reinventing percpu_counters
> > badly.
> > 
> > I'm just not seeing it.
> 
> 
> The first version of the patch does a qtoken_reap_cache to reap the
> tokens into pool before doing an accounting of the tokens and the token
> count will be precise.  It was not done in the second version of the
> patch due to objection that it may be  costly, and also the tokens count
> will be fluctuating anyway.  However, qtoken_avail is not called very
> often (usually caller will use qtoken_get to access the tokens and it
> will not need a total accounting of the tokens). We can do it the
> previous way and there will be no inaccuracies. 
> 

afacit, your proposed implementation could have used percpu_counters. 
If so, that would be by far the best way of doing it, because that
doesn't require the addition of new infrastructure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/