Re: [PATCH] x86, hweight: Fix UML boot crash

[Geert Uytterhoeven]

2010/6/14 Toralf FÃrster <toralf.foerster@xxxxxx>:
> Borislav Petkov wrote at 15:00:39
>
>> Linus' tree doesn't contain the fix yet - rather it is in -tip:
>> http://git.kernel.org/tip/055c47272b8f5679d08ccc57efea3cb4aaeb5fc6
>>
>> You can easily cherry-pick it from there and retest.
> Issue solved works with that patch.
>
> FWIW : This command sequence produced a linux executable which crashed too:
>
> $> ~/devel/linux-2.6 $ patch -p1 < ../linux-2.6-
> tip.git-055c47272b8f5679d08ccc57efea3cb4aaeb5fc6.patch patching file
> arch/um/include/asm/arch_hweight.h
>
> $> ~/devel/linux-2.6 $ make ARCH=um CC="ccache gcc"
> make[1]: `arch/um/sys-i386/user-offsets.s' is up to date.
> ÂCHK Â Â include/linux/version.h
> ÂCHK Â Â include/generated/utsrelease.h
> ÂCALL Â Âscripts/checksyscalls.sh
> ÂCHK Â Â include/generated/compile.h
> ÂLINK linux
> $> start_uml.sh
> ...
>
> But after I compiled it w/o ccache
>
> $> ~/devel/linux-2.6 $ make ARCH=um
>
> linux executable works (!?!)

I assume you did a `make clean' in between?
So could this just be the problem that new include files early in the
include path are
not detected by the dependency system, as they aren't in any *.d file?

BTW, I'm also using ccache. Always. Ever. All my (cross)compilers are symlinks
to ccache ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/