Re: BUG: using smp_processor_id() in preemptible code: s2disk

[Arjan van de Ven]

On Mon, 14 Jun 2010 17:54:40 +0300
Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:

> On (06/14/10 07:38), Arjan van de Ven wrote:
> > > Hello,
> > > Not sure if this simple solution is the correct one.
> > 
> > it's not; the caller needs to pass in the cpu number I suspect for
> > this to be really correct....
> > 
> > I just returned from family emergency travel and will take a look
> > today
> > 
> 
> I thought about patching
> 
> ./drivers/cpuidle/governors/menu.c:	if (nr_iowait_cpu())
> ./drivers/cpuidle/governors/menu.c:	mult += 10 *
> nr_iowait_cpu(); ./kernel/time/tick-sched.c:		if
> (nr_iowait_cpu() > 0)
> 
> 
> decided to patch nr_iowait_cpu instead.

the bug is that it needs to be

nr_iowait_cpu(int cpu)



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/