Re: [PATCH 12/12] usb: use IRQ watching

From: Greg KH
Date: Mon Jun 14 2010 - 18:17:27 EST


On Mon, Jun 14, 2010 at 11:52:10PM +0200, Tejun Heo wrote:
> Hello,
>
> On 06/14/2010 11:41 PM, Greg KH wrote:
> > So if there's a routing problem, it turns into a polled interrupt? Do
> > we really want that?
>
> Oh yeah, I really want that for libata. Routing is only part of the
> problem and flaky IRQ is something we have to learn to cope with.
>
> > I wonder how long people will run without realizing that there are
> > problems with their system if their devices still work.
>
> I think things would be better this way. If the drives (both cd and
> hard) / input devices are not accessible, most people would simply
> give up rather than reporting, and many cases are transient problems
> which happen only once in the blue moon.
>
> It would be great if some kind of automatic reporting can be used
> (similar to kerneloops?). Hmm... maybe make the warnings scarier?

If you throw a WARN(), then kerneloops will pick it up, so you should be
fine there.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/