Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' setbut not used

[Justin P. Mattock]

On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
> Em 14-06-2010 23:26, Justin P. Mattock escreveu:
> > not sure if this is correct or not for
> > fixing this warning:
> >    CC [M]  drivers/media/common/tuners/tuner-simple.o
> > drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
> > drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
> >
> >   Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>
> >
> > ---
> >   drivers/media/common/tuners/tuner-simple.c |    4 +---
> >   1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
> > index 8abbcc5..4465b99 100644
> > --- a/drivers/media/common/tuners/tuner-simple.c
> > +++ b/drivers/media/common/tuners/tuner-simple.c
> > @@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
> >   	struct tuner_simple_priv *priv = fe->tuner_priv;
> >   	u8 config, cb;
> >   	u16 div;
> > -	struct tunertype *tun;
> >   	u8 buffer[4];
> >   	int rc, IFPCoff, i;
> >   	enum param_type desired_type;
> >   	struct tuner_params *t_params;
> >
> > -	tun = priv->tun;
> > -
> > +	
> Why are you adding an extra blank line here? Except for that, the patch
> looks sane.
>
> >   	/* IFPCoff = Video Intermediate Frequency - Vif:
> >   		940  =16*58.75  NTSC/J (Japan)
> >   		732  =16*45.75  M/N STD

o.k. resent this.. I ended up doing
a git reset do make sure things dont get
funky etc..

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/