Re: Appending '+' to version, since 2.6.35-rc2

[Benny Halevy]

On Jun. 13, 2010, 15:01 -0400, Mark Hills <mark@xxxxxxxxxxx> wrote:
> Commit 85a256d adds a new feature:
> 
>   [...] When CONFIG_LOCALVERSION_AUTO is not enabled, a `+' is appended
>   to the kernel version to represent that the kernel has been revised
>   since the last release unless "make LOCALVERSION=" was used to uniquely
>   identify the build.
> 
> I'm finding this inconvenient for 'casual' kernel development.
> 
> For example, my usual workflow goes something like:
> 

FWIW, I agree with this.
If I wanted a version suffix of this sort I'd just use CONFIG_LOCALVERSION_AUTO.

Benny

> 1) find something I suspect is a bug
> 2) upgrade to the latest stable or -rc kernel, to confirm
> 3) experiment with patch to fix it
> 
> Since 2.6.35-rc2, going from step 2 to 3 causes the version of the kernel 
> to change: forcing time-consuming rebuilds, installing modules, and manual 
> changes associated with a new version number; eg. updating the lilo/grub 
> config, or the distribution's initrd.
> 
> Whilst I can understand the motivation for the '+' being mandatory, the 
> added stages above unnecessarily raise the bar for casual developers, or 
> other people who need to 'dip' into the kernel and test patches. These 
> people are least likely to be aware of using LOCALVERSION to override it 
> too.
> 
> May I suggest that this particular part of the commit be reverted (example 
> below)? In favour of a user, if they wish, explicitly setting LOCALVERSION 
> or using CONFIG_LOCALVERSION_AUTO.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/